vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.61k stars 1.39k forks source link

Mark InProgress backup/restore as failed upon requeuing #7863

Closed kaovilai closed 2 months ago

kaovilai commented 3 months ago

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7207

Please indicate you've done the following:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 58.78%. Comparing base (a8d77ea) to head (5e52668).

Files Patch % Lines
pkg/controller/restore_controller.go 52.38% 9 Missing and 1 partial :warning:
pkg/controller/backup_controller.go 66.66% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7863 +/- ## ========================================== - Coverage 58.80% 58.78% -0.02% ========================================== Files 345 345 Lines 28759 28777 +18 ========================================== + Hits 16911 16917 +6 - Misses 10420 10431 +11 - Partials 1428 1429 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaovilai commented 2 months ago

Closing as we prefer simpler retry approach which would not be as complicated for future reconciler work like requeue.