search

vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.61k stars 1.39k forks source link

Bump the Ginkgo version to v2 #7872

Open blackpiglet opened 3 months ago

blackpiglet commented 3 months ago

Describe the problem/challenge you have

Ginkgo v2 supports more features, and the Ginkgo v1 is not maintained anymore. https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#upgrading-to-ginkgo-20 https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#aborting-the-test-suite

Propose to upgrade the Velero E2E using Ginkgo to v2 to utilize the new functionality.

Describe the solution you'd like

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

kaovilai commented 3 months ago

We've done this in OADP in the past. If you can break the tasks out I can assist here.

blackpiglet commented 3 months ago

@kaovilai Great. Were there any issues or PRs on the OADP side that I can take as a reference?

kaovilai commented 3 months ago

This is the main one we did to move to v2 https://github.com/openshift/oadp-operator/pull/560

I think we had a mix of both in go.mod initially but eventually removed v1 references.

kaovilai commented 3 months ago

Last v1 removal was simply

-   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/v2"
blackpiglet commented 3 months ago

@kaovilai Thanks. After reading some Ginkgo documents, I broke this Epic task into sub-tasks. I'm still getting familiar with the Ginkgo framework. There could be something inaccurate, or something important is still missing. Appreciate any help.