vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.4k stars 1.37k forks source link

Deprecate Changing PVC selected-node feature #7904

Open Lyndon-Li opened 1 week ago

Lyndon-Li commented 1 week ago

The Changing PVC selected-node feature is not required and not working well, so we need to deprecate it. Details as below:

  1. It is not required --- the feature was used to fix a limitation of old Kubernetes versions, but since Kubernetes 1.16, the limitation has been fixed
  2. It conflicts with the principle of WaitForFirstConsumer, so it doesn't work with WaitForFirstConsumer mode volume
  3. From the description here, the volume.kubernetes.io/selected-node annotation is an output of the scheduler, so changing it is more like a hack
reasonerjt commented 1 week ago

In v1.15 let's just print a warning and add a document. According to the process, we'll remove it in n+2, i.e. v1.17