vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.4k stars 1.37k forks source link

In backup sync flow put snapshotHandle as source in CSI VSContent #7924

Open anshulahuja98 opened 4 days ago

anshulahuja98 commented 4 days ago

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue) https://kubernetes.io/docs/concepts/storage/volume-snapshots/ image

Context: We have few customers which have used same storage bucket across clusters, as a result of that their VSContents are syncing across clusters, After the sync the other cluster does not have permission on the snapshot of original cluster, it starts to rePUT the snapshot. This leads to significant load on the CSI driver.

Please indicate you've done the following:

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (b0dc189) to head (d1d331f).

Files Patch % Lines
pkg/controller/backup_sync_controller.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7924 +/- ## ========================================== - Coverage 58.79% 58.77% -0.03% ========================================== Files 345 345 Lines 28766 28768 +2 ========================================== - Hits 16914 16908 -6 - Misses 10423 10430 +7 - Partials 1429 1430 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.