vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.57k stars 1.39k forks source link

Labeler workflow do not trigger changelog-check workflow. #8066

Open kaovilai opened 1 month ago

kaovilai commented 1 month ago

What steps did you take and what happened:

Velero labeler currently use GITHUB_TOKEN and do not trigger changelog-check to rerun which requires PR to either have another commit/push or require close/open of PRs to pass changelog check.

We need to add either a Personal Access Token or GitHub App installation access token to the following workflow to solve. https://github.com/vmware-tanzu/velero/blob/4dfbacd2a1738701824b40a92e37c7bf291c93fa/.github/workflows/auto_label_prs.yml

If you do want to trigger a workflow from within a workflow run, you can use a GitHub App installation access token or a personal access token instead of GITHUB_TOKEN to trigger events that require a token. ref

What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

kaovilai commented 1 month ago

Alternative is to merge the changelog check into labeler workflow and use conditions to gate if changelog check should be passing.