search

vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.79k stars 1.41k forks source link

Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go #8297

Open kaovilai opened 1 month ago

kaovilai commented 1 month ago

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8296 Similar to https://github.com/vmware-tanzu/velero-plugin-for-aws/pull/210

To test this PR, you would create aws BSL without region and attempt to backup using kopia/data mover

Please indicate you've done the following:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (b34e011) to head (69b456a). Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/config/aws.go 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8297 +/- ## ========================================== + Coverage 59.18% 59.20% +0.01% ========================================== Files 367 367 Lines 30838 30846 +8 ========================================== + Hits 18253 18261 +8 - Misses 11124 11125 +1 + Partials 1461 1460 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

shubham-pampattiwar commented 1 month ago

cc: @reasonerjt

reasonerjt commented 1 month ago

@shubham-pampattiwar @sseago @kaovilai

LGTM, but shall we hold it after the branch is cut for v1.15? Unfortunately we see issues in the internal pipeline and still fixing it.

sseago commented 1 month ago

@reasonerjt since this isn't a 1.15 regression (the bug is there in 1.14 as well), I don't think it's a 1.15 blocker. I'm fine with holding off until the branch is cut, and then we can target for 1.15.1. @kaovilai Does that work for you?

kaovilai commented 1 month ago

Sure