search

vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.79k stars 1.41k forks source link

Revert "Expose VSC SourceVolumeMode" 1.14 #8302

Closed msfrucht closed 1 month ago

msfrucht commented 1 month ago

Please add a summary of your change

This reverts commit 7580538f031a1b998353c660fe0a6501e3866379.

Does your change fix a particular issue?

At best, this issue should be added to site documentation troubleshooting.

The underlying issue was a downlevel csi-snapshotter container from an ancient Rook install that used inadvertently without much thought.

Changing the SourceVolumeMode fails to fix the issue. It cannot be fixed in Velero as the issue was requests from the csi-snapshotter container.

While I do not believe the existing change will cause problems, the should make it easier for the maintainers to remove.

Fixes #(issue) See https://github.com/vmware-tanzu/velero/issues/8259#issuecomment-2411819708

Please indicate you've done the following:

/kind changelog-not-required

msfrucht commented 1 month ago

/kind changelog-not-required

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.73%. Comparing base (2636f5b) to head (5d4d7fd). Report is 2 commits behind head on release-1.14.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.14 #8302 +/- ## ================================================ + Coverage 58.71% 58.73% +0.01% ================================================ Files 346 346 Lines 28841 28840 -1 ================================================ + Hits 16935 16940 +5 + Misses 10476 10471 -5 + Partials 1430 1429 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.