vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.78k stars 1.41k forks source link

fix: use Contains or ErrorContains with testify #8322

Closed mmorel-35 closed 1 month ago

mmorel-35 commented 1 month ago

Thank you for contributing to Velero!

Please add a summary of your change

use Contains or ErrorContains with testify

Does your change fix a particular issue?

It uses (assert|require).Contains(t,...) or (assert|require).ErrorContains(t, err,...) when possible It also removes (assert|require).Error(t, err,...) as it is redundant with (assert|require).ErrorContains(t, err,...) behavior

Please indicate you've done the following:

mmorel-35 commented 1 month ago

/kind changelog-not-required

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.99%. Comparing base (732b87b) to head (d06601e). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8322 +/- ## ========================================== - Coverage 59.17% 58.99% -0.19% ========================================== Files 367 367 Lines 30849 38847 +7998 ========================================== + Hits 18256 22918 +4662 - Misses 11130 14467 +3337 + Partials 1463 1462 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaovilai commented 1 month ago

Please close and reopen PRs

8066

anshulahuja98 commented 1 month ago

Hopefully this is okay to merge before 1.15 RC.