vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.78k stars 1.41k forks source link

Set automountServiceAccountToken: false in SA and Pod #8325

Open anshulahuja98 opened 1 month ago

anshulahuja98 commented 1 month ago

Describe the problem/challenge you have

This issue is both for here and for https://github.com/vmware-tanzu/helm-charts Based on security guidelines, we have received asks for setting the flag - automountServiceAccountToken: false in SA and pods. https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#opt-out-of-api-credential-automounting

Describe the solution you'd like

automountServiceAccountToken: false on Velero pod and SA

Anything else you would like to add:

If anyone has already tested this with velero and not seen any surprises, please pitch in.

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

reasonerjt commented 1 month ago

I wish to suggest we refrain from making such a change. B/C setting it to false may break a lot of downstream integrations...

anshulahuja98 commented 1 month ago

thanks for your input. Would it be possible for you to share what type of potential issues we might see due to this? I am not pushing for immediately fixing this. Trying to get data on the type of issues we can expect. Let me know if you have any idea on specific known issues.