Closed sseago closed 1 week ago
Attention: Patch coverage is 50.00000%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 58.95%. Comparing base (
d0cffa3
) to head (6588141
). Report is 26 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
From the design it's not clear to me if threads will always be running, or started as needed. Could you clarify?
The thread creation won't be part of this PR, but the threads are long-running goroutines with the configured amount always available -- the main reason for this was that when we eventually expand this to allow multiple backups running at once, these goroutines will be shared among the running backups. So if, for example, you've configured 10 concurrent ItemBlocks and 2 concurrent backups, then there will be 10 threads processing blocks from both backups.
(from the design): "The worker pool will be started by calling RunItemBlockWorkers in backupReconciler.SetupWithManager, passing in the worker count and reconciler context" https://github.com/vmware-tanzu/velero/blob/main/design/backup-performance-improvements.md
Thank you for contributing to Velero!
Please add a summary of your change
This is the second PR related to phase 2 for backup performance improvements which adds a new flag
--item-block-worker-count
to velero install and server commands.Follow-on PRs will use this value to determine the number of goroutines to start for processing ItemBlocks
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.