vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.78k stars 1.41k forks source link

Issue 8394: move closeDataPath outside callbacks #8395

Closed Lyndon-Li closed 1 week ago

Lyndon-Li commented 1 week ago

Fix issue #8394, don't call closeDataPath in VGDP callbacks, otherwise, the VGDP cleanup will hang

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (1fbd22f) to head (e5d6c48). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/pod_volume_backup_controller.go 0.00% 5 Missing :warning:
pkg/controller/pod_volume_restore_controller.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8395 +/- ## ========================================== - Coverage 58.96% 58.95% -0.02% ========================================== Files 367 367 Lines 38895 38902 +7 ========================================== Hits 22933 22933 - Misses 14500 14507 +7 Partials 1462 1462 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.