vmware-tanzu / vm-operator

Self-service manage your virtual infrastructure...
Other
106 stars 48 forks source link

UserData should not be optional for Sysprep / should throw error sooner #790

Closed prziborowski closed 3 weeks ago

prziborowski commented 3 weeks ago

What steps did you take and what happened?

https://github.com/vmware-tanzu/vm-operator/blob/284063573075c66e7b068a81cfdb064752519053/api/v1alpha3/sysprep/sysprep.go#L45 I left out userData and the request was accepted, but during the customize request to VC it returned InvalidArgument("spec.identity.userData.fullName") as these are all required fields.

What did you expect to happen?

I just assumed the optional + omitempty meant it was, and possibly customization would be skipped, or this portion would be.

Is there anything else you would like to add?

I'd be happy if the webhook rejected the request so it fails fast.

Please tell us about your environment.

I'm just a proxy for this. Replace all the "I" with a teammate's name.