`VmTemplate_ListByDatacenter` requires two arguments as identified by

vmware / PowerCLI-Example-Scripts

http://blogs.vmware.com/powercli

Other

753 stars 603 forks source link

`VmTemplate_ListByDatacenter` requires two arguments as identified by #435

Closed mtelvers closed 3 years ago

mtelvers commented 3 years ago

@TheRealBenForce in #431. I have looked back to PowerCLI 6.5 and this was the case back then as well and not a new 12.2 change.

VmTemplate_ListByDatacenter            Method
VMware.Hv.VmTemplateInfo[] VmTemplate_ListByDatacenter(
  VMware.Hv.Services service, VMware.Hv.DatacenterId datacenter
  )

Without wanting to steal anyones credit I've created a PR for this change.

TheRealBenForce commented 3 years ago

Thanks @mtelvers .

TheRealBenForce commented 3 years ago

@mtelvers at what point does version can incremented? Reason why I ask is because I load this module into a private repository internal for my enterprise. This module has been approved for use but the others in the full repository have not.

mtelvers commented 3 years ago

@TheRealBenForce according to the GitHub history , the module has been at version 1.3.1 for 15 months and there have been lots of commits in that time. I'm not sure on what the policy is on incrementing it. We'd need guidance from the maintainers. From your perspective I guess you'd rather the version didn't change very often!

TheRealBenForce commented 3 years ago

@mtelvers , no I would ideally have the module version updated each time anything in the Vmware.Hv.Pool changes. I can't really upload new code using the same version number to the private repository in my enterprise. This module is a bit of a thorn in my side. Our normal process would be to get a module from PowershellGallery approved and have our private repository pull in a new version whenever it changes in Gallery.