search

vmware / PowerCLI-Example-Scripts

http://blogs.vmware.com/powercli
Other
746 stars 603 forks source link

Update VMware.HV.Helper.psm1 #515

Closed imtrinity94 closed 2 years ago

imtrinity94 commented 2 years ago

Add Rebuild-HVMachine function Signed-off-by: Mayank Goyal imtrinity94@gmail.com

vmwclabot commented 2 years ago

@imtrinity94, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

kamennikolov commented 2 years ago

Looks good. Please sign your submit using 'git commit --amend --signoff' and we'll merge it.

imtrinity94 commented 2 years ago

Not sure how to use this "git commit --amend --signoff" from here onwards.

imtrinity94 commented 2 years ago

Could you please point me to some article/blog?

kamennikolov commented 2 years ago

Hi, Here are some stack overflow topics on this: https://stackoverflow.com/questions/13457203/how-to-add-the-signed-off-by-field-in-the-git-patch https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

vmwclabot commented 2 years ago

@imtrinity94, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

imtrinity94 commented 2 years ago

I made this commit on another pull request(522) using the command you mentioned. @kamennikolov

image
imtrinity94 commented 2 years ago

By the way, does this requires git bash to complete this merge process and does it not possible to successfully merge a rquest just from GUI here that can also fix the dco-required thing? I am tired of trying now. nothing seem to work.

kamennikolov commented 2 years ago

I have successfully merged the other change.

imtrinity94 commented 2 years ago

cool thanks