search

vmware / PowerCLI-Example-Scripts

http://blogs.vmware.com/powercli
Other
746 stars 603 forks source link

New-HVPool -Spec /path/to/file honor minNumberOfMachine attribute #525

Closed cadegenn closed 2 years ago

cadegenn commented 2 years ago

This merge request tries to fix issue #524 Hope it helps. Thank you.

vmwclabot commented 2 years ago

@cadegenn, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

cadegenn commented 2 years ago

Hi, My bad, I didn't known about signing off commits. To be honest I didn't known it even existed. I found how to sign off new commits, but not how to sign existing commits. So what can I do now ? Is it possible to sign off existing commits ? Do I have to delete this pull-request and start over ? Thank you.

kamennikolov commented 2 years ago

You should be able to amend the commit using "git commit --amend --signoff"

cadegenn commented 2 years ago

I think that git commit --amend --signoff will modify only not-pushed-yet commit am I wrong ? Maybe I'd better off starting this pull request over ?

kamennikolov commented 2 years ago

git comit --amend will change the last commit. Then you should be able to push it again with -Force. switch. You can see more details here: https://linuxize.com/post/change-git-commit-message/

vmwclabot commented 2 years ago

@cadegenn, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

cadegenn commented 2 years ago

Hi, I finally manage to sign-off and force-push my commits. Hope I did it right. thank you

kamennikolov commented 2 years ago

Everything looks great now. I'm merging your changes.