search

vmware / PowerCLI-Example-Scripts

http://blogs.vmware.com/powercli
Other
743 stars 602 forks source link

Initial VMware.Skyline.InsightsAPI Module #546

Closed bwuch closed 2 years ago

bwuch commented 2 years ago

This module consumes the Skyline Insights API which is documented here: https://docs.vmware.com/en/VMware-Skyline/1.0/skyline-api-guide/GUID-92213394-4ADD-4A35-BD36-DC77397E249D.html.

kamennikolov commented 2 years ago

Looks fine now. The only thing left to figure out is the 429 retry logic. Have you ever managed to reproduce this error and test the retry logic?

kamennikolov commented 2 years ago

I would discuss with the product team about the timeout between the requests. A limit of 2 requests per second is not adequate for an API that's expected to be used in automation scenarios. And this waiting for 500ms between the requests hurts the performance of the script.