vmware / ansible-for-nsxt

Ansible delivers simple IT automation that ends repetitive tasks and frees up DevOps teams for more strategic work. This project is to enable this automation for NSX-T installation.
Other
171 stars 145 forks source link

Modify shebang to use ansible_python_interpreter #459

Open austlane opened 1 year ago

austlane commented 1 year ago

The vmware.ansible-for-nsxt module currently breaks ansible module convention by using the env shebang.

#!/usr/bin/env python

From the Ansible Docs:

Using #!/usr/bin/env, makes env the interpreter and bypasses ansible_<interpreter>_interpreter logic.

On machines without a symlink from python to python3, the current implementation is broken.

With this change, the python interpreter is selected by the ansible_python_interpreter.

See:

vmwclabot commented 1 year ago

@austlane, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.