vmware / ansible-for-nsxt

Ansible delivers simple IT automation that ends repetitive tasks and frees up DevOps teams for more strategic work. This project is to enable this automation for NSX-T installation.
Other
171 stars 140 forks source link

Ansible manager facts modules #471

Closed Priyanka-Middha closed 1 year ago

Priyanka-Middha commented 1 year ago

Ansible manager facts modules are failing with "Input byte array has incorrect ending byte at 20" error

Description: Cursor key value pair in request param was getting appended instead of updation in the next iteration after pagination was introduced for MP modules.

For example: url = "https://10.196.179.73/api/v1/logical-switches?cursor=0041-8605035095901123965.-7350981255833053930MTY4NDkyMzAzMTE4Mw==&cursor=0041-5880602792106442526.-6188807095818619501MTY4NDkyMzExOTgxNw=="

Fix provided: To resolve this issue, now we are using python in build libraries instead of having our own logic to update the cursor from urllib.parse import urlparse, parse_qs, urlencode, unquote, urlunparse

BugId:3214989

vmwclabot commented 1 year ago

@Priyanka-Middha, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 1 year ago

@Priyanka-Middha, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.