search

vmware / ansible-for-nsxt

Ansible delivers simple IT automation that ends repetitive tasks and frees up DevOps teams for more strategic work. This project is to enable this automation for NSX-T installation.
Other
171 stars 140 forks source link

fix recursive pagination bug #482

Open laidbackware opened 11 months ago

laidbackware commented 11 months ago

The current pagination implementation doesn't work due to a recursive loop bug that was created in PR https://github.com/vmware/ansible-for-nsxt/pull/469.

The request function contains a while loop which calls itself, triggers the while loop, and on and on.

The only way to implement correctly is to wrap the request function and have the while loop run outside of the request function.

This fix should be back ported to all legacy branches as it is version agnostic.

laidbackware commented 11 months ago

@kaushiklele Can you review please. Let me know if you have any questions and we can talk on VMware Slack.

vmwclabot commented 10 months ago

@laidbackware, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.