vmware / ansible-for-nsxt

Ansible delivers simple IT automation that ends repetitive tasks and frees up DevOps teams for more strategic work. This project is to enable this automation for NSX-T installation.
Other
171 stars 145 forks source link

Replaced `#!/usr/bin/env python` with `#!/usr/bin/python` #509

Closed AllRWeak closed 5 days ago

AllRWeak commented 4 months ago

Staring from Ansible 2.17.1 modules in this collection are unable the find the Python interpreter. According to This issue https://github.com/ansible/ansible/issues/83603 and Ansible development guide https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding all modules should start with #!/usr/bin/python

This PR replaces #!/usr/bin/env python with #!/usr/bin/python in all modules to make sure they match with Ansible module format and fixes https://github.com/vmware/ansible-for-nsxt/issues/508

This fix has also been tested on Ansible 2.17.0 to make sure it's also backwards compatible.

vmwclabot commented 4 months ago

@AllRWeak, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 4 months ago

@AllRWeak, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

rutgerblom commented 1 month ago

When will this PR get merged?

laidbackware commented 1 month ago

@ggverma when will this be merged?

luischanu commented 1 month ago

When will this be merged?

helarnl commented 3 weeks ago

This issue did take some time to figure out what problem was. When will this be merged?

alainstucki commented 2 weeks ago

when this will be merged?

luischanu commented 5 days ago

Thank you for merging this PR!