search

vmware / ansible-vsphere-gos-validation

Guest OS validation test set for vSphere using Ansible
Other
39 stars 29 forks source link

Change to skip running included tasks when condition not meet and refine unnecessary filter #607

Closed Tomorrow9 closed 2 months ago

Tomorrow9 commented 2 months ago

Some | lower and | bool are not necessary since the variable is already in the lower case or bool type when defined and set.

Tomorrow9 commented 2 months ago 
VM information:
+----------------------------------------------------------------------------------+
| Name                      | test_vm                                              |
+----------------------------------------------------------------------------------+
| Guest OS Distribution     | RedHat 9.4 x86_64                                    |
+----------------------------------------------------------------------------------+
| IP                        |                                                                |
+----------------------------------------------------------------------------------+
| GUI Installed             | True                                                 |
+----------------------------------------------------------------------------------+
| CloudInit Version         | 23.4                                                 |
+----------------------------------------------------------------------------------+
| Hardware Version          | vmx-14                                               |
+----------------------------------------------------------------------------------+
| VMTools Version           | 12.3.5 (build-22544099)                              |
+----------------------------------------------------------------------------------+
| Config Guest Id           | rhel8_64Guest                                        |
+----------------------------------------------------------------------------------+
| Guest Short Name          |                                                      |
+----------------------------------------------------------------------------------+
| GuestInfo Guest Id        | rhel9_64Guest                                        |
+----------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Red Hat Enterprise Linux 9 (64-bit)                  |
+----------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                           |
+----------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                   |
|                           | bitness='64'                                         |
|                           | cpeString='cpe:/o:redhat:enterprise_linux:9::baseos' |
|                           | distroAddlVersion='9.4 (Plow)'                       |
|                           | distroName='Red Hat Enterprise Linux'                |
|                           | distroVersion='9.4'                                  |
|                           | familyName='Linux'                                   |
|                           | kernelVersion='5.14.0-427.13.1.el9_4.x86_64'         |
|                           | prettyName='Red Hat Enterprise Linux 9.4 (Plow)'     |
+----------------------------------------------------------------------------------+

Test Results (Total: 31, Passed: 29, Skipped: 2, Elapsed Time: 02:44:12)
+-------------------------------------------------------------------------+
| ID | Name                                 |   Status        | Exec Time |
+-------------------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3    |   Passed        | 00:31:28  |
| 02 | check_inbox_driver                   |   Passed        | 00:01:30  |
| 03 | ovt_verify_pkg_install               |   Passed        | 00:06:56  |
| 04 | ovt_verify_status                    |   Passed        | 00:03:21  |
| 05 | vgauth_check_service                 |   Passed        | 00:01:21  |
| 06 | host_verify_saml_token               |   Passed        | 00:02:26  |
| 07 | check_ip_address                     |   Passed        | 00:01:10  |
| 08 | check_os_fullname                    |   Passed        | 00:01:41  |
| 09 | stat_balloon                         |   Passed        | 00:01:05  |
| 10 | stat_hosttime                        |   Passed        | 00:01:11  |
| 11 | device_list                          |   Passed        | 00:02:58  |
| 12 | check_quiesce_snapshot_custom_script |   Passed        | 00:01:35  |
| 13 | memory_hot_add_basic                 |   Passed        | 00:05:56  |
| 14 | cpu_hot_add_basic                    |   Passed        | 00:05:49  |
| 15 | cpu_multicores_per_socket            |   Passed        | 00:08:25  |
| 16 | check_efi_firmware                   |   Passed        | 00:01:19  |
| 17 | secureboot_enable_disable            |   Passed        | 00:04:47  |
| 18 | e1000e_network_device_ops            |   Passed        | 00:04:50  |
| 19 | vmxnet3_network_device_ops           |   Passed        | 00:03:51  |
| 20 | pvrdma_network_device_ops            |   Passed        | 00:08:30  |
| 21 | gosc_perl_dhcp                       |   Passed        | 00:06:14  |
| 22 | gosc_perl_staticip                   |   Passed        | 00:06:00  |
| 23 | gosc_cloudinit_dhcp                  |   Passed        | 00:07:15  |
| 24 | gosc_cloudinit_staticip              |   Passed        | 00:07:15  |
| 25 | paravirtual_vhba_device_ops          |   Passed        | 00:07:32  |
| 26 | lsilogic_vhba_device_ops             | * Not Supported | 00:01:03  |
| 27 | lsilogicsas_vhba_device_ops          | * Not Supported | 00:01:08  |
| 28 | sata_vhba_device_ops                 |   Passed        | 00:07:44  |
| 29 | nvme_vhba_device_ops                 |   Passed        | 00:07:32  |
| 30 | nvdimm_cold_add_remove               |   Passed        | 00:07:30  |
| 31 | ovt_verify_pkg_uninstall             |   Passed        | 00:03:28  |
+-------------------------------------------------------------------------+
Tomorrow9 commented 2 months ago 
VM information:
+-------------------------------------------------------------------------------------------+
| Name                      | test_vm                                                       |
+-------------------------------------------------------------------------------------------+
| Guest OS Distribution     | Microsoft Windows 11 Enterprise 10.0.26100.0 64-bit           |
+-------------------------------------------------------------------------------------------+
| IP                        |                                              |
+-------------------------------------------------------------------------------------------+
| Hardware Version          |                                                         |
+-------------------------------------------------------------------------------------------+
| VMTools Version           |                                |
+-------------------------------------------------------------------------------------------+
| Config Guest Id           | windows11_64Guest                                             |
+-------------------------------------------------------------------------------------------+
| GuestInfo Guest Id        | windows11_64Guest                                             |
+-------------------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Microsoft Windows 11 (64-bit)                                 |
+-------------------------------------------------------------------------------------------+
| GuestInfo Guest Family    | windowsGuest                                                  |
+-------------------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                            |
|                           | bitness='64'                                                  |
|                           | buildNumber='26100'                                           |
|                           | distroName='Windows'                                          |
|                           | distroVersion='10.0'                                          |
|                           | familyName='Windows'                                          |
|                           | kernelVersion='26100.1150'                                    |
|                           | prettyName='Windows 11 Enterprise, 64-bit (Build 26100.1150)' |
+-------------------------------------------------------------------------------------------+

Test Results (Total: 30, Passed: 29, Failed: 1, Elapsed Time: 05:00:55)
+---------------------------------------------------------------+
| ID | Name                              |   Status | Exec Time |
+---------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3 |   Passed | 00:48:36  |
| 02 | windows_online_updates_install    |   Passed | 00:49:17  |
| 03 | check_inbox_driver                |   Passed | 00:02:18  |
| 04 | secureboot_enable_disable         |   Passed | 00:09:34  |
| 05 | wintools_complete_install_verify  |   Passed | 00:13:42  |
| 06 | check_efi_firmware                |   Passed | 00:01:04  |
| 07 | check_ip_address                  |   Passed | 00:01:11  |
| 08 | check_os_fullname                 |   Passed | 00:00:59  |
| 09 | mouse_driver_vmtools              |   Passed | 00:00:53  |
| 10 | vgauth_check_service              |   Passed | 00:00:53  |
| 11 | host_verify_saml_token            |   Passed | 00:05:45  |
| 12 | stat_balloon                      |   Passed | 00:00:53  |
| 13 | stat_hosttime                     |   Passed | 00:01:05  |
| 14 | paravirtual_vhba_device_ops       |   Passed | 00:08:26  |
| 15 | lsilogicsas_vhba_device_ops       |   Passed | 00:08:28  |
| 16 | sata_vhba_device_ops              |   Passed | 00:08:26  |
| 17 | nvme_vhba_device_ops              |   Passed | 00:08:31  |
| 18 | nvme_vhba_device_ops_spec13       |   Passed | 00:11:12  |
| 19 | nvme_disk_hot_extend_spec13       |   Passed | 00:07:18  |
| 20 | nvdimm_cold_add_remove            | * Failed | 00:05:00  |
| 21 | e1000e_network_device_ops         |   Passed | 00:07:12  |
| 22 | vmxnet3_network_device_ops        |   Passed | 00:06:00  |
| 23 | memory_hot_add_basic              |   Passed | 00:06:40  |
| 24 | check_quiesce_snapshot            |   Passed | 00:03:48  |
| 25 | cpu_multicores_per_socket         |   Passed | 00:15:57  |
| 26 | gosc_sanity_staticip              |   Passed | 00:18:42  |
| 27 | gosc_sanity_dhcp                  |   Passed | 00:25:39  |
| 28 | vtpm_cold_add_remove              |   Passed | 00:09:11  |
| 29 | wintools_uninstall_verify         |   Passed | 00:07:41  |
| 30 | cpu_hot_add_basic                 |   Passed | 00:04:57  |
+---------------------------------------------------------------+
Tomorrow9 commented 2 months ago

Have you tested with existing VM? If not, I suggest you test one.

Do you mean cover testing on physical testbed or existing VM? What's the concern?

123lzxm commented 2 months ago

Have you tested with existing VM? If not, I suggest you test one.

Do you mean cover testing on physical testbed or existing VM? What's the concern?

Existing VM. To avoid the scenarios that the vars are only initialized in new VM.