search

vmware / ansible-vsphere-gos-validation

Guest OS validation test set for vSphere using Ansible
Other
41 stars 30 forks source link

Add autoinstall support for Fedora Workstation #612

Closed linhuali closed 4 months ago

linhuali commented 4 months ago

Test Results (Total: 31, Passed: 23, Skipped: 8, Elapsed Time: 02:10:20) +-------------------------------------------------------------------------+ | ID | Name | Status | Exec Time | +-------------------------------------------------------------------------+ | 01 | deploy_vm_efi_lsilogic_vmxnet3 | Passed | 00:29:50 | | 02 | check_inbox_driver | Passed | 00:01:49 | | 03 | ovt_verify_pkg_install | Passed | 00:07:12 | | 04 | ovt_verify_status | Passed | 00:03:14 | | 05 | vgauth_check_service | Passed | 00:01:12 | | 06 | host_verify_saml_token | Passed | 00:02:45 | | 07 | check_ip_address | Passed | 00:01:01 | | 08 | check_os_fullname | Passed | 00:01:37 | | 09 | stat_balloon | Passed | 00:00:57 | | 10 | stat_hosttime | Passed | 00:00:55 | | 11 | device_list | Passed | 00:03:10 | | 12 | check_quiesce_snapshot_custom_script | Passed | 00:01:30 | | 13 | memory_hot_add_basic | Passed | 00:07:33 | | 14 | cpu_hot_add_basic | Not Supported | 00:00:01 | | 15 | cpu_multicores_per_socket | Passed | 00:09:16 | | 16 | check_efi_firmware | Passed | 00:01:00 | | 17 | secureboot_enable_disable | Passed | 00:04:37 | | 18 | e1000e_network_device_ops | Passed | 00:04:36 | | 19 | vmxnet3_network_device_ops | Passed | 00:03:34 | | 20 | pvrdma_network_device_ops | Not Supported | 00:00:52 | | 21 | gosc_perl_dhcp | Not Supported | 00:01:04 | | 22 | gosc_perl_staticip | Not Supported | 00:00:57 | | 23 | gosc_cloudinit_dhcp | Not Supported | 00:00:43 | | 24 | gosc_cloudinit_staticip | Not Supported | 00:00:58 | | 25 | paravirtual_vhba_device_ops | Passed | 00:08:00 | | 26 | lsilogic_vhba_device_ops | Not Supported | 00:00:55 | | 27 | lsilogicsas_vhba_device_ops | Not Supported | 00:00:58 | | 28 | sata_vhba_device_ops | Passed | 00:08:13 | | 29 | nvme_vhba_device_ops | Passed | 00:08:12 | | 30 | nvdimm_cold_add_remove | Passed | 00:08:27 | | 31 | ovt_verify_pkg_uninstall | Passed | 00:03:46 | +-------------------------------------------------------------------------+

keirazhang commented 4 months ago

I saw Fedora workstation's pretty name has Workstation Edition keywords. Can you also update linux/utils/get_os_edition.yml to set guest_os_edition for Fedora? You can directly extract edition from guest_os_release.PRETTY_NAME (guest_os_release has been set in linux/utils/get_os_release.yml. For example,

# Get fedora edition
- set_fact:
      fedora_edition: "{{ guest_os_release.PRETTY_NAME | regex_search('(\\w+) Edition', '\\1', ignorecase=true) }}"

# Then set guest_os_edition:
- set_fact:
       guest_os_edition: "{{ fedora_edition | first }}"
   when: fedora_edition | length > 0

This should be put a block for Fedora and when guest_os_release.PRETTY_NAME is defined

linhuali commented 4 months ago

Fedora 40 Workstation:

+--------------------------------------------------------------------------------+
| Name                      | Fedora-Workstation-40-EFI-Open-VM-Tools            |
+--------------------------------------------------------------------------------+
| Guest OS Distribution     | Fedora 40 Workstation x86_64                       |
+--------------------------------------------------------------------------------+
| GUI Installed             | True                                               |
+--------------------------------------------------------------------------------+
| Hardware Version          | vmx-20                                             |
+--------------------------------------------------------------------------------+
| VMTools Version           | 12.4.0 (build-23259341)                            |
+--------------------------------------------------------------------------------+
| Config Guest Id           | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Id        | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Red Hat Fedora (64-bit)                            |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                         |
+--------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                 |
|                           | bitness='64'                                       |
|                           | cpeString='cpe:/o:fedoraproject:fedora:40'         |
|                           | distroAddlVersion='40 (Workstation Edition)'       |
|                           | distroName='Fedora Linux'                          |
|                           | distroVersion='40'                                 |
|                           | familyName='Linux'                                 |
|                           | kernelVersion='6.9.9-200.fc40.x86_64'              |
|                           | prettyName='Fedora Linux 40 (Workstation Edition)' |
+--------------------------------------------------------------------------------+

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:26:10)
+-------------------------------------------------------------+
| ID | Name                              | Status | Exec Time |
+-------------------------------------------------------------+
|  1 | deploy_vm_efi_paravirtual_vmxnet3 | Passed | 00:25:49  |
+-------------------------------------------------------------+