search

vmware / antrea-operator-for-kubernetes

Antrea Operator for Kubernetes deployments
Other
15 stars 12 forks source link

Generate all Antrea-derived object in Make #62

Closed ksamoray closed 2 years ago

ksamoray commented 2 years ago

The operator repo contains multiple objects which are derived from Antrea. Instead of having multiple targets where each generates a specific object while pulling an Antrea repo, the change replaces these with a single target - antrea-resources. This target triggers a script which fetches and builds antrea manifest, role lists in their various locations, and configuration samples. The change also defines some required makefile dependencies.

Signed-off-by: Kobi Samoray ksamoray@vmware.com

ksamoray commented 2 years ago

@jwsui so generating and copying into both deploy/kubernetes and deploy/openshift at the same place is wrong - as the generated result can be either for kubernetes or openshift but never for both. I'll revise this change and the make targets.

ksamoray commented 2 years ago

BTW while we create the yamls for kubernetes, the image value should still be antrea-ubi? or should it be antrea-ubuntu?

jwsui commented 2 years ago

BTW while we create the yamls for kubernetes, the image value should still be antrea-ubi? or should it be antrea-ubuntu?

Good point, I think antrea-ubuntu should be used on kubernetes.