search

vmware / antrea-operator-for-kubernetes

Antrea Operator for Kubernetes deployments
Other
15 stars 12 forks source link

Upgrade Golang and Openshift module #77

Closed jwsui closed 1 year ago

jwsui commented 1 year ago

Bump golang version to 1.19 to sync with Antrea and fix some golang runtime CVEs. And upgrade Openshift related module to fix CVEs imported by these modules(and their dependencies).

ksamoray commented 1 year ago

Change LGTM, can you check the build failure? Seems like make generate fails even though it depends on make controller-gen

jwsui commented 1 year ago

Change LGTM, can you check the build failure? Seems like make generate fails even though it depends on make controller-gen

Starting in Go 1.17, installing executables with go get is deprecated. go install may be used instead.

Thanks, I thinks this is the reason, so use go install instead of go get after upgrading to go 1.19.

ksamoray commented 1 year ago

Note that role.yaml files under /deploy are auto-generated by make targets, as roles are mostly inherited from Antrea resources. Therefore changes to these files will be overwritten. Roles which are only required by the operator should be placed in config/rbac/role_base.yaml (or role_base_ocp.yaml if they're specific to OpenShift). See doc/release-process.md for details.

jwsui commented 1 year ago

Note that role.yaml files under /deploy are auto-generated by make targets, as roles are mostly inherited from Antrea resources. Therefore changes to these files will be overwritten. Roles which are only required by the operator should be placed in config/rbac/role_base.yaml (or role_base_ocp.yaml if they're specific to OpenShift). See doc/release-process.md for details.

patch is required by apply.ApplyObject for every object from antrea.yaml. So I update generate-role-yaml.py to add verb patch to each object and changes under /deploy won't be overwritten as generate-role-yaml.py is changed.