search

vmware / antrea-operator-for-kubernetes

Antrea Operator for Kubernetes deployments
Other
15 stars 12 forks source link

Replace version/version.go with internal/version/version.go #91

Closed antoninbas closed 9 months ago

antoninbas commented 9 months ago

On case-insensitive filesystems (which includes default macOS installations), it is not possible to have a "version" directory and a "VERSION" file in the same parent directory, and the repo cannot be cloned succesfully. To resolve this, we replace version/version.go with internal/version/version.go.

Additionally, we stop using "0.0.1" as the version string, as it is not consistent with the contents of the VERSION file, nor with the Docker tag. Instead, we use the VERSION file as the one source of truth. We also add a "--version" command-line flag to the operator binary, which displays the version and exits.

antoninbas commented 9 months ago

@ksamoray not sure what to do with https://github.com/vmware/antrea-operator-for-kubernetes/tree/main/olm-catalog It has multiple references to version 0.0.1, is this folder actually used for anything (it has not been updated in 3 years)?

ksamoray commented 9 months ago

@ksamoray not sure what to do with https://github.com/vmware/antrea-operator-for-kubernetes/tree/main/olm-catalog It has multiple references to version 0.0.1, is this folder actually used for anything (it has not been updated in 3 years)?

It's an old leftover which isn't in use.I'll delete it.