Michaelpalacce
commented
1 year ago @jskirde This is an issue with a missing <description> in the pom.xml. I think you managed to find this out? 😄
closing it for now
Closed jskirde closed 1 year ago
Michaelpalacce
commented
1 year ago @jskirde This is an issue with a missing <description> in the pom.xml. I think you managed to find this out? 😄
closing it for now
jskirde
commented
1 year ago Please re-open. This needs to be fixed.
ivo-kotev
commented
1 year ago @jskirde - actually the behavior that you explained is most probably caused by the default shell that is set in VS Code and the escaping / detecting the proper shell is something that vRDT ( the VS Code Plugin) is doing. One suggestion - set your VS Code shell to git-bash - then most probably you will no longer have the above issue.
Anyway the problem is still valid and leaving this open until it's fixed in the vrealize-developer-tools repo or this case is cloned there.
The VS Code plugin is hosted here: https://github.com/vmware/vrealize-developer-tools
jskirde
commented
1 year ago This issue is present when using git-bash. The problem appears to be the line breaks in the description of the "o11n-actions-package-maven-plugin" package are not handled by vropkg.cmd. Even when using git-bash, vropkg.cmd is still called.
kjiju
commented
1 year ago When description is not provided in pom.xml, the description is copied from BTVA.
The arraylist: vroPkgCmd from two scenarios is printed below. withoutDescription vroPkgCmd=[C:\development\demo-jiju\vro\node_modules\@vmware-pscoe\vropkg\bin\vropkg.cmd, --in, tree, --srcPath, C:\development\demo-jiju\vro\target\vro-sources\xml, --out, flat, --destPath, C:\development\demo-jiju\vro\target\vropkg, --privateKeyPEM, target/archetype.keystore-2.0.1/private_key.pem, --certificatesPEM, target/archetype.keystore-2.0.1/cert.pem, --keyPass, VMware1!, --version, 1.0.0-SNAPSHOT, --packaging, package, --artifactId, vro, --description, Build Tools for VMware Aria provides development and release management tools for implementing automation solutions based on the VMware Aria Suite and VMware Cloud Director. The solution enables Virtual Infrastructure Administrators and Automation Developers to use standard DevOps practices for managing and deploying content., --groupId, onboarding]
withDescription vroPkgCmd=[C:\development\demo-jiju\vro\node_modules\@vmware-pscoe\vropkg\bin\vropkg.cmd, --in, tree, --srcPath, C:\development\demo-jiju\vro\target\vro-sources\xml, --out, flat, --destPath, C:\development\demo-jiju\vro\target\vropkg, --privateKeyPEM, target/archetype.keystore-2.0.1/private_key.pem, --certificatesPEM, target/archetype.keystore-2.0.1/cert.pem, --keyPass, VMware1!, --version, 1.0.0-SNAPSHOT, --packaging, package, --artifactId, vro, --description, This package is licensed under onboarding, --groupId, onboarding]
kjiju
commented
1 year ago This issue is present when using git-bash. The problem appears to be the line breaks in the description of the "o11n-actions-package-maven-plugin" package are not handled by vropkg.cmd. Even when using git-bash, vropkg.cmd is still called.
Fixed this in AbstractVroPkgMojo.java
By applying following solution.
String descStr = "";
if (project.getDescription() != null) {
descStr = project.getDescription();
}
this.description = descStr.replaceAll("\\R", " ");
Description
vRealize: Push actions fails on Windows with build tools v2.30.0+
Steps to Reproduce
Preconditions:
Expected behavior:
Actual behavior:
[ERROR] Missing groupIdReproduces how often:
Component/s:
Affects Build/s:
Environment
Client
Server
Failure Logs
Related issues and PRs
N/A
Additional Context
I suspect this issue is caused by invoking the vropkg.cmd file with a multi-line description. It looks like this truncated the command passed to vropkg and results in the missing groupId.