search

vmware / cloud-director-named-disk-csi-driver

Container Storage Interface (CSI) driver for VMware Cloud Director
Other
27 stars 31 forks source link

Volume metrics #62

Closed erdembas closed 2 years ago

erdembas commented 2 years ago

Is your feature request related to a problem? Please describe.

I am trying to monitor PVs and am not able to get the kubelet_volume_stats_available_bytes because it is no longer supported by default in the node exporter.

Describe the solution you'd like

Include the metrics similar to how the AWS EBS CSI driver did it. I think CSI drivers themselves need to implement these metrics since k8s v1.13 or something around there though I could be wrong.

Issue: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/524 PR: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/677

Digital Ocean CSI PR : https://github.com/digitalocean/csi-digitalocean/pull/197

VSphere Implementation : https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/d288ab214ed6d62b2d29e4e0c6e3cf0522d4fc16/pkg/csi/service/node.go#L232

Describe alternatives you've considered

I've been trying to get my relabel configs right to monitor a group of PVs and am not able to get the PV name out of the node exporter to be able to match node_filesystem_free_bytes to the right PV. This is broadly needed to monitor sensitive PVs running on VKE that might need volumes added to the array as they will up.

Additional context

No response

erdembas commented 2 years ago

Hi @arunmk, Any progress on this? Using disk metrics without monitoring will cause problems. @arunmk

arunmk commented 2 years ago

@erdembas we have been busy with a few releases. This PR should provide metrics.