search

vmware / cloud-provider-for-cloud-director

Kubernetes External Cloud Provider for VMware Cloud Director
Other
19 stars 29 forks source link

TCP health check removed from LB when scaling cluster #281

Open vxav opened 1 year ago

vxav commented 1 year ago

Describe the bug

When nodes are added or removed, the TCP health check is removed from the load balancer in VCD.

When the deprecated machine IP gets removed from the LB, the TCP check is removed at the same time and not recreated.

Reproduction steps

  1. Create a service type load balancer
  2. Ensure it has the TCP health check enabled
  3. Add a replica to the machineDeployment
  4. Observe that the TCP check is no longer in the LB ...

Expected behavior

The TCP check should remain at all times.

Additional context

No response

ltimothy7 commented 12 months ago

Hi @vxav Thank you for opening this. We have tried to reproduce this by resizing the worker nodes and control plane nodes separately, but the health check is still up. Have you been able to reproduce this issue?

vxav commented 11 months ago

This is strange, I checked again and I had the same behaviour:

What CPI version do you run? We're on 1.2.0

ltimothy7 commented 11 months ago

We used CPI 1.4.0. Are you able to try 1.4.0 to see if this is fixed in the newer version?

If 1.2.0 just has the issue, we can make it a known issue

ltimothy7 commented 10 months ago

@vxav Just following up on this; otherwise, we can close the issue

vxav commented 10 months ago

@ltimothy7 Sorry for the delayed reply. I tested with 1.4.1 and it is the same behaviour.

vxav commented 10 months ago

I confirm the following behaviour:

ltimothy7 commented 9 months ago

Thank you @vxav For clarity, would you please list the instructions you are performing to check the TCP health check? For example, is it at the lb pool level or virtual service level?

Are you also scaling the machine Deployment by just scaling a worker node pool in the Container UI plugin?

Thank you

vxav commented 9 months ago

Yes I scale the machineDeployment CR and we don't use the UI.

For the health check it is indeed on the LB Pool that I check.

mnspodrska commented 9 months ago

We have used GUI and got the same result of health check being removed after adding new node. Cloud Director 10.5 CSE 4.1.1a TKG Product Version v2.2.0 Kubernetes Version v1.25.7+vmware.2 CAPVCD Version v1.1.1 CPI (Cloud Provider Interface) cloud-controller-manager 1.4.1

vxav commented 3 months ago

Hey @ltimothy7, any news on this?