search

vmware / cloud-provider-for-cloud-director

Kubernetes External Cloud Provider for VMware Cloud Director
Other
20 stars 30 forks source link

Add `node.kubernetes.io/instance-type` label to nodes #312

Open viveksyngh opened 1 year ago

viveksyngh commented 1 year ago

Is your feature request related to a problem? Please describe.

We would like to add node.kubernetes.io/instance-type labels to nodes provisioned using CAPVCD similar to other cloud provider node.kubernetes.io/instance-type.

https://kubernetes.io/docs/reference/labels-annotations-taints/#nodekubernetesioinstance-type

Describe the solution you'd like

We can add the sizing policy of VCDMachine object as instanceType of the nodes. These labels can be added as metadata in init or join configuration of the nodes.

Check the original issue https://github.com/vmware/cluster-api-provider-cloud-director/issues/536

Describe alternatives you've considered

No response

Additional context

No response

srekkas commented 2 months ago

Would be nice to have labels e.g. worker pool name, instance size (large, medium ..)