vmware / cloud-provider-for-cloud-director

Kubernetes External Cloud Provider for VMware Cloud Director
Other
20 stars 30 forks source link

Add support for Datacenter Group network in CPI #378

Closed rocknes closed 4 months ago

rocknes commented 4 months ago

CPI didn't support Datacenter Group networks because the method GetNsxtEdgeGatewayByName can't handle datacenter group networks. In this PR we have replaced the method with GetNsxtEdgeGatewayById to avoid the issue.

Additionally, added support for Proxy in SwaggerClient.

Testing done: on a fresh VCD 10.5.1 setup

The test passing proves that now CPI can handle Data center group networks.

Note : The VCD testbed is deployed in a private VLAN and can be accessed only via a proxy, hence the modification to SwaggerClient. Govcd client is already proxy aware.

Fixes : https://bugzilla.eng.vmware.com/show_bug.cgi?id=3397729