vmware / container-service-extension

Container Service for VMware vCloud Director
https://vmware.github.io/container-service-extension
Other
77 stars 52 forks source link

[VCDA-4174] getting control plane ip through vapp without sleep #1389

Closed ltimothy7 closed 2 years ago

ltimothy7 commented 2 years ago

This change is Reviewable

vmwclabot commented 2 years ago

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

ltimothy7 commented 2 years ago

container_service_extension/def_/cluster_service.py line 2136 at r1 (raw file):

Previously, sakthisunda (Sakthi Sundaram) wrote…
I meant, please suggest if they also should be also replaced.

Yes, I agree with you that these should be replaced. I will add it in tech debt

ltimothy7 commented 2 years ago

container_service_extension/def_/cluster_service.py line 2136 at r1 (raw file):

Previously, ltimothy7 wrote…
Yes, I agree with you that these should be replaced. I will add it in tech debt

I added the following task for CSE (not tech debt):

https://jira.eng.vmware.com/browse/VCDA-4177

ltimothy7 commented 2 years ago

container_service_extension/def_/cluster_service.py line 2136 at r1 (raw file):

Previously, ltimothy7 wrote…
I added the following task for CSE (not tech debt): https://jira.eng.vmware.com/browse/VCDA-4177

Note: the combination of using ubuntu 20 + VCD 10.3.3.2 may be the issue