vmware / dod-compliance-and-automation

Security hardening content for VMware solutions to US Department of Defense standards
Other
153 stars 61 forks source link

Updated Control 000067 xPath code #231

Closed leebeck3 closed 4 months ago

leebeck3 commented 7 months ago

was throwing an error when ran

Tested on Aria 8.16 with Inspec 4.18 tests included:

  1. commenting out ErrorReportValve
  2. changing showServerInfo to true
  3. removing showServerInfo

known/potential issues: report valve will still match so long as ErrorReportValve, shouldn't be an issue unless typos happen. doesn't scan for every host value, assumed it wasn't needed for this could be fixed with a count or something similar:

its(["count(//Host[not(Valve[contains(@className, 'ErrorReportValve')])]) | //Host[Valve[contains(@className, 'ErrorReportValve')]/@showServerInfo != 'false'])"]) { should cmp [0] }

vmwclabot commented 7 months ago

@leebeck3, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 7 months ago

@leebeck3, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 7 months ago

@leebeck3, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide a valid address

vmwclabot commented 7 months ago

@leebeck3, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

freddyfeelgood commented 7 months ago

@leebeck3 Can you provide the details of the ruby error you're getting? Also, do you get the same error if you upgrade your inspec version and retry?

leebeck3 commented 7 months ago

yep, here you go:

Unknown XML object received (Array): []

No way to elevate my version currently.

vmwclabot commented 6 months ago

@leebeck3, VMware has approved your signed contributor license agreement.