vmware / dscr-for-vmware

The Repository contains Microsoft PowerShell Desired State Configuration (DSC) Resources for managing VC and ESXi settings.
Other
140 stars 41 forks source link

Making sure that both Configuration and configuration work #335

Open bielawb opened 1 year ago

bielawb commented 1 year ago

While working with VMware DSC in PowerShell 7 I noticed a weird issue where creating configuration with lower case keyword would result in an error. It appears that for whatever reason, configuration keyword is removed using TrimStart. IMO, that is a terrible choice:

To limit the amount of changes, I'm simply adding lower case c to the list of chars that are being trimmed, but I'd suggest using something different entirely to replace any combination of CoNfIgUrAtIoN that authors may come up with, as PowerShell is for sure not case-sensitive in the keyword realm, but VMware DSC appears to be exactly that.

vmwclabot commented 1 year ago

@bielawb, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 1 year ago

@bielawb, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.