Also filter out @ from field names

vmware / fluent-plugin-vmware-loginsight

Fluentd plugin to forward logs to VMware Aria Operations for Logs

Other

10 stars 13 forks source link

Also filter out @ from field names #10

Closed msolberg closed 4 years ago

msolberg commented 4 years ago

We had a situation where a fluentd field name had a @ in it. This was causing 400 errors like so:

Response Code: 400 Response Message: Response Body: {"errorMessage":"Invalid message field name"})

This change resolves that issue by adding @ to the list of special characters which get substituted before being sent over.

vmwclabot commented 4 years ago

@msolberg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 3175a4095976a12480f5c87747bb5542fb4fa0af must be signed by msolberg@redhat.com
Commit 0093accbf5216ee36293df261baef4b814ce4997 must be signed by msolberg@redhat.com

msolberg commented 4 years ago

I tried to amend my commit and resubmit the pull request, but it's still complaining. Let me know if you want me to submit another pull request.

mohitevishal commented 4 years ago

Hi @msolberg Looks like the commits needs to be signed. Can you please sign them? You have 3 commits so you'll need to sign all of them or you can squash the commits and resubmit the patch.

msolberg commented 4 years ago

I've submitted another pull request with a single signed off commit.