vmware / go-ipfix

An ipfix library in Go
Other
40 stars 27 forks source link

Add "egressNodeName" field for Egress information support #343

Closed Atish-iaf closed 8 months ago

Atish-iaf commented 8 months ago

Add a new field egressNodeName for the visibility of Egress information in flow records.

vmwclabot commented 8 months ago

@Atish-iaf, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Atish-iaf commented 8 months ago

Hi @antoninbas @heanlan Please help to review this PR. Thanks

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (073bf85) 72.73% compared to head (de98a58) 72.88%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vmware/go-ipfix/pull/343/graphs/tree.svg?width=650&height=150&src=pr&token=448A94JZ59&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://app.codecov.io/gh/vmware/go-ipfix/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #343 +/- ## ========================================== + Coverage 72.73% 72.88% +0.14% ========================================== Files 19 19 Lines 2853 2854 +1 ========================================== + Hits 2075 2080 +5 + Misses 604 602 -2 + Partials 174 172 -2 ``` | [Flag](https://app.codecov.io/gh/vmware/go-ipfix/pull/343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/vmware/go-ipfix/pull/343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | `52.90% <ø> (+2.24%)` | :arrow_up: | | [unit-tests](https://app.codecov.io/gh/vmware/go-ipfix/pull/343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | `71.75% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/vmware/go-ipfix/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [pkg/registry/registry\_antrea.go](https://app.codecov.io/gh/vmware/go-ipfix/pull/343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-cGtnL3JlZ2lzdHJ5L3JlZ2lzdHJ5X2FudHJlYS5nbw==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vmware/go-ipfix/pull/343/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)
heanlan commented 8 months ago

Hi @Atish-iaf , go-ipfix v0.9.0 is released. Please feel free to use this tag in Antrea repository.