search

vmware / go-ipfix

An ipfix library in Go
Other
39 stars 27 forks source link

When running build_registry.go multiple times, we hit resource not modified http error 304 #98

Open srikartati opened 3 years ago

srikartati commented 3 years ago

Describe the bug With code generation check worflow, we run build_registry.go multiple times in quick succession. During its run, we do http.get on https://www.iana.org/assignments/ipfix/ipfix-information-elements.csv. There is cache control introduced on this link/resource, so we hit the error 304. Because of this error, we generate empty pkg/registry/registry_IANA.go file. In addition, because of this code generation check workflow fails on PRs.

To Reproduce Run the following commands multiple times in quick succession: go run pkg/registry/build_registry/build_registry.go

Expected behavior Even with multiple runs of build_registry.go, we should see proper generation of the file, pkg/registry/registry_IANA.go with all the info elements in it.

Actual Behavior Because of this HTTP error, we generate empty go file.

Versions master branch ToT.

Additional context Add any other context about the problem here.

srikartati commented 3 years ago

Temporarily skipping registry generation check workflow that is there as part of code generation check. This is done through PR #92