vmware / govmomi

Go library for the VMware vSphere API
Apache License 2.0
2.32k stars 913 forks source link

Add "AggregatedSnapshotCapacityInMb" to CnsSnapshotCreateResult and CnsSnapshotDeleteResult. #3362

Closed lipingxue closed 9 months ago

lipingxue commented 9 months ago

Description

This change is to add "AggregatedSnapshotCapacityInMb" to CnsSnapshotCreateResult and CnsSnapshotDeleteResult.

Type of change

Please mark options that are relevant:

How Has This Been Tested?

Run unit test. In the unit test result, field "AggregatedSnapshotCapacityInMb" is available in CnsSnapshotCreateResult and CnsSnapshotDeleteResult

client_test.go:355: Creating snapshot using the spec: []types.CnsSnapshotCreateSpec{
            {   
                VolumeId: types.CnsVolumeId{
                    Id: "1cf88bdc-0b1d-4198-b995-50319ed6865d",
                },
                Description: "example-vanilla-block-snapshot",
            },      
        }       
    client_test.go:379: snapshotCreateResult: &types.CnsSnapshotCreateResult{
            CnsSnapshotOperationResult: types.CnsSnapshotOperationResult{},
            Snapshot:                   types.CnsSnapshot{
                SnapshotId: types.CnsSnapshotId{
                    Id: "c517f616-68fe-4dfb-a5e2-f022584139cd",
                },
                VolumeId: types.CnsVolumeId{
                    Id: "1cf88bdc-0b1d-4198-b995-50319ed6865d",
                },
                Description: "example-vanilla-block-snapshot",
                CreateTime:  time.Now(),
            },
            AggregatedSnapshotCapacityInMb: 0,
        }   

 client_test.go:512: Deleting snapshot using the spec: []types.CnsSnapshotDeleteSpec{
            {   
                VolumeId: types.CnsVolumeId{
                    Id: "1cf88bdc-0b1d-4198-b995-50319ed6865d",
                },  
                SnapshotId: types.CnsSnapshotId{
                    Id: "c517f616-68fe-4dfb-a5e2-f022584139cd",
                },
            },  
        }       
    client_test.go:536: snapshotDeleteResult: &types.CnsSnapshotCreateResult{
            CnsSnapshotOperationResult: types.CnsSnapshotOperationResult{},
            Snapshot:                   types.CnsSnapshot{
                SnapshotId: types.CnsSnapshotId{
                    Id: "c517f616-68fe-4dfb-a5e2-f022584139cd",
                },
                VolumeId: types.CnsVolumeId{
                    Id: "1cf88bdc-0b1d-4198-b995-50319ed6865d",
                },
                Description: "example-vanilla-block-snapshot",
                CreateTime:  time.Now(),
            },
            AggregatedSnapshotCapacityInMb: 0,
        }

Checklist: