ISSUE-3337: Fix bug in vcsim - vim.VirtualMachine.snapshot property c…

bardielle commented 4 months ago

…auses runtime error when not set

Description

This is a hotfix that solving the issue 3337 vcsim: vim.VirtualMachine.snapshot property causes runtime error when not set

Closes: #(3337)

Type of change

I saw that if VirtualMachine.snapshot wasn't set I'm getting the error runtime error: index out of range [0] with length 0

That due to obj.MissingSet is empty

Please mark options that are relevant:

[ V] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Build related change

How Has This Been Tested?

Running a create VM request without snapshot against vcsim

Checklist:

[ ] My code follows the CONTRIBUTION guidelines of this project
[ V] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ V] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

vmwclabot commented 4 months ago

@bardielle, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

bardielle commented 4 months ago

@dougm

vmwclabot commented 4 months ago

@bardielle, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 2 months ago

@bardielle, VMware has approved your signed contributor license agreement.

vmware / govmomi