govc: Add feature to pass fullname and org for windows vm customization

rubinthomasdev commented 1 month ago

Description

Added two new flags to pass the fullname and org for windows vm customization mandatory parameters.

Closes: #3443

Type of change

Please mark options that are relevant:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. If applicable, please also list any relevant details for your test configuration.

[x] run below command to test that the vm is getting customized successfully

govc vm.customize -vm=<windows-vm-name> -u="<vcenter-url>" -dc="<datacenter-name>" -ip=<vm-ip> -netmask=<netmask> -gateway=<gateway-ip> -name=<windows-vm-name> -type=Windows -domain="<domain-name>" -username="firsname lastname" -org="myorg"

Checklist:

[x] My code follows the CONTRIBUTION guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

vmwclabot commented 1 month ago

@rubinthomasdev, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 1 month ago

@rubinthomasdev, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

rubinthomasdev commented 1 month ago

Thank you @dougm for the review. I have done the following changes based on the review :

run make doc to update the govc doc
removed the unnecessary check on empty strings and restructured the code based on the example above (thank you for the example).

rubinthomasdev commented 3 weeks ago

@dougm Thank you for the suggestion. This makes the document more user friendly with Windows only : tag added. I have added the update and squashed and force pushed the changes.

vmwclabot commented 3 weeks ago

@rubinthomasdev, VMware has approved your signed contributor license agreement.

vmware / govmomi