api: add sata controller - Githubissues

vmware / govmomi

Go library for the VMware vSphere API

Apache License 2.0

2.26k stars 896 forks source link

api: add sata controller #3458

Open tenthirtyam opened 1 month ago

tenthirtyam commented 1 month ago

Description

Adds support for creating SATA controllers.

Closes: #1219

Type of change

Please mark options that are relevant:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Build related change

How Has This Been Tested?

[x] Local test: TestCreateSATAController

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestCreateSATAController$ github.com/vmware/govmomi/object

ok      github.com/vmware/govmomi/object    (cached)

Checklist:

[x] My code follows the CONTRIBUTION guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged