vmware / govmomi

Go library for the VMware vSphere API
Apache License 2.0
2.26k stars 896 forks source link

Add support for "High with Hyperthreading" option for latency_sensitivity #3468

Open Guerckan opened 2 weeks ago

Guerckan commented 2 weeks ago

Is your feature request related to a problem? Please describe. As introduced by vSphere 8.0, the "latency sensitivity" virtual machine setting now has a new possible value named "High with Hyperthreading". See VMWare documentation supporting this statement : (https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-vm-administration/GUID-F5DAC793-7B13-418F-949E-0CD80CEC5D1E.html)

Current implementation in https://github.com/vmware/govmomi/blob/bf28314d9e3287ad1674f80d8a80d2245c0159ae/vim25/types/enum.go#L4846-L4881 does not support this new value and as such projects relying on this library cannot offer this new feature.

See https://github.com/hashicorp/terraform-provider-vsphere/issues/2169 as an example.

Describe the solution you'd like I would like for the "LatencySensitivitySensitivityLevel" type string to support the new value "High with Hyperthreading".

Describe alternatives you've considered Alternative solution right now is to settle for "High" but this setting is particularly interesting for network appliances virtual machines and the new functionality of "high with hyperthreading" offers a way to reduce the computing power footprint of a latency sensitivity "high" setting on the host without sacrificing much of its advantages.

Additional context N/A

github-actions[bot] commented 2 weeks ago

Howdy 🖐   Guerckan ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.