govc: Add '-size' flag to datastore.create

HaruChebrolu commented 2 months ago

Closes: #3519

Description

govc: Add support for providing size while we create a VMFS datastore

Type of change

Please mark options that are relevant:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[ ] Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. If applicable, please also list any relevant details for your test configuration.

[ ] Test Description 1 Tried to create a VMFS datastore without size argument in govc cli, so that it takes the entire size of disk into consideration(default case) go run main.go datastore.create -type VMFS -name vmfs61 -version 6 -disk eui.b8fa2f975ecc490ea090a46404568540 ocsqe-virt07.lab.eng.blr.redhat.com
[ ] Test Description 2 Tried to create a VMFS datastore with some size in govc cli go run main.go datastore.create -type VMFS -name vmfs61 -version 6 -disk eui.b8fa2f975ecc490ea090a46404568540 -size 30 ocsqe-virt07.lab.eng.blr.redhat.com

Checklist:

[x] My code follows the CONTRIBUTION guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

HaruChebrolu commented 2 months ago

@dougm I've been attempting to run make doc multiple times after rebasing, but each time I encounter the same error from the GitHub action. I've also tried running ./usage.sh > USAGE.md directly, but the error persists. Could you please assist me in resolving this issue?

Closed https://github.com/vmware/govmomi/pull/3528, as I thought that there was some issue with my previous branch.

dougm commented 2 months ago

@dougm I've been attempting to run make doc multiple times after rebasing, but each time I encounter the same error from the GitHub action. I've also tried running ./usage.sh > USAGE.md directly, but the error persists. Could you please assist me in resolving this issue?

Hi @HaruChebrolu , you just need to rebase with latest vmware/govmomi main since a new govc command has been added. Then run make doc again

dougm commented 2 months ago

@HaruChebrolu , not sure what you did, but now there are 6 commits.. I'm going to fix it and force push to your branch

vmwclabot commented 2 months ago

@HaruChebrolu, VMware has approved your signed contributor license agreement.

vmware / govmomi