api: Update folder.PlaceVMsXCluster to support several placement types

derekbeard commented 1 month ago

Description

The PlaceVmsXCluster API is being updated to provide placement recommendations for several new "op-types", relocate and reconfigure, in addition to the original "createAndPowerOn" behavior. To support the new capability, the PlaceVmsXCluster API is updated to add a new placement type field, add 2 new supported placement types (relocate and reconfigure) and to extend the spec and faults to carry addition info referencing existing VMs and an optional relocate spec.

This change does the following:

extends the API definitions to reflect the changes.
extends the simulator to support these new placement types.
adds simulator tests to validate the new placement types.

NOTE: This still a draft that needs more testing.

Type of change

Please mark options that are relevant:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Build related change

How Has This Been Tested?

go test -v -count=20 ./simulator -run TestPlaceVmsXClusterReconfigure go test -v -count=20 ./simulator -run TestPlaceVmsXClusterRelocate go test -v -count=20 ./simulator -run TestPlaceVmsXClusterCreateAndPowerOn make check make test (failing with other unrelated tests, which I'll look into). TBD: Additional integration testing

Checklist:

[x] My code follows the CONTRIBUTION guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

dougm commented 1 month ago

Realizing we don't mention this in the doc, but we have scripts/license.sh - only touches files you'd see with git diff --name-status main

derekbeard commented 1 month ago

I'm root causing that unit test issue, not obvious from the test output.

dougm commented 1 month ago

I'm root causing that unit test issue, not obvious from the test output.

Looks like an infra flake, we get test flakes too. You can re-run from here: https://github.com/vmware/govmomi/actions/runs/11020367271 w/ Re-run failed jobs

vmware / govmomi