vmware / guest-introspection-nsx

Guest Introspection for VMware NSX
Other
12 stars 8 forks source link

Fix Version Packing #10

Closed apunde closed 5 years ago

apunde commented 5 years ago

Problem Description Fix Version Packing to avoid collisions.

Fix Description Pack version into 32 bit integer assigning each byte for major, minor, build and revision. Earlier scheme was prone to collisions. (Producing same integer for different versions.)

Testing Details Make succeeds

Syslog vmw_conn_notify[31796]: INFO: vmw_pack_version: vmw_conn_notify protocol version 1.1.0.0 0x1010000 vmw_conn_notify[31796]: INFO: vmw_handshake_version: Adding client to the client connection list socket 7 version 1010000 protocol 0

Impact on existing Inter Process Communication

This change updates the version to 1.1.0.0 As the newer code is not compatible with 1.0 version, the minor version is incremented.

For working with the current version, clients need to make change and interpret version properly. For example, current version will be encoded as 0x1100 in the protocol.

Issue 5