search

vmware / kube-fluentd-operator

Auto-configuration of Fluentd daemon-set based on Kubernetes metadata
Other
319 stars 100 forks source link

Support for injecting podLabels to the daemonset when deploying using the helm-chart #422

Open gilles-o opened 1 year ago

gilles-o commented 1 year ago

Is your feature request related to a problem? Please describe.

What?

The current Helm-Chart does not support extraLabels on the pods of the daemonset.

We're using your awesome fluentd operator in an azure-AKS context, where we use workload-identity (a built-in mechanism that allows azure-authentication of pods via managed-identities) to give pods access to various azure resources (retrieving secrets from azure key-vault, for instance.

Why? In order to enable the workload-identity mechanism, it's mandatory to add a specific label to the concerned pods.

Describe the solution you'd like

What seems the easiest is to enable an optional podLabels via values.yaml that is applied to the daemonset resource.

Describe alternatives you've considered

No response

Additional context

No response

slimm609 commented 11 months ago

Thanks for opening this. We are open to contributions for this if possible, otherwise we will work on prioritizing it properly

gilles-o commented 11 months ago

Thanks for opening this. We are open to contributions for this if possible, otherwise we will work on prioritizing it properly

...I tried to do that, but as not able to push my branch into your repo... Nos sure what process I need to follow to be granted that permission... Thanks for letting me know