search

vmware / kube-fluentd-operator

Auto-configuration of Fluentd daemon-set based on Kubernetes metadata
Other
319 stars 100 forks source link

fix: arm64 image is actually x86 #423

Closed nhamlh closed 11 months ago

nhamlh commented 11 months ago

BUILDPLATFORM is host platform architecture, in this case, Github Action runner, not the architecture of produced image artifact.

From the screenshot bellow we can see that linux/arm64 image sourced photon x86: image

vmwclabot commented 11 months ago

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 11 months ago

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 11 months ago

@nhamlh, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

slimm609 commented 11 months ago

DCO was removed due to github rebase. bypassing since it was signed above