vmware / load-balancer-and-ingress-services-for-kubernetes

Load Balancer and Ingress services for Kubernetes
Other
97 stars 57 forks source link

Image tag should be overridable #476

Open carpenterm opened 3 years ago

carpenterm commented 3 years ago

In the AKO chart the image tag is hard coded:

image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"

We rebuild all of our open source images in our own repository and apply a build date suffix. We can't use the chart as it is without modifying it.

Standard practice is to allow the image tag to be overridden and have the image tag supplied in the default values.yaml file. Like this:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
lknite commented 8 months ago

Implementing the vmware bitnami common library & standards would also resolve this request:

dependencies:
  - name: common
    repository: oci://registry-1.docker.io/bitnamicharts
    tags:
      - bitnami-common
    version: 2.x.x

Established patterns to then follow would be: image

and image