search

vmware / open-vm-tools

Official repository of VMware open-vm-tools project
http://sourceforge.net/projects/open-vm-tools/
2.25k stars 425 forks source link

Build with gRPC 1.51 fails #676

Open cpaelzer opened 1 year ago

cpaelzer commented 1 year ago

Describe the bug

Build in Debian started to fail with newer gRPC and was reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025491

Here is a full Debian build log with the fail retrying against the most recent 12.2.5 open-vm-tools-failing-grpc1.51.txt

Reproduction steps

  1. install current libgrpc-dev 1.51.1-3+b2
  2. install all other build dependencies
  3. Build open-vm-tools

Expected behavior

Build correctly even with the new gRPC

Additional context

There was a fix proposed in the Debian bug which fixes the build. You might have a look at that at https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=1025491;filename=open-vm-tools_grpc.patch;msg=5

johnwvmw commented 1 year ago

@cpaelzer

Actually VMware recently resync'ed our internal open-vm-tools test builds to use the latest Debian / Ubuntu open-vm-tools build source. The patch patches/debian/grpc_1.51 was in that source tree.

We have integrated the pull request #664 with the slight change in configure.ac as shown in comment response. With that modified pull request integrated, we are internally building and testing without the "grpc_1.51" patch for:

Ubuntu 23.04 (lunar) with libgrpc++1.51/lunar,now 1.51.1-3build3 amd64 [installed,automatic] Debian 12 (bookworm) with libgrpc++1.51/stable,stable,now 1.51.1-3+b1 amd64 [installed,automatic]

The pull request is in the upcoming open-vm-tools 12.3.0 release.