search

vmware / open-vmdk

Apache License 2.0
113 stars 46 forks source link

Honor compiler/linker flags from the environment #42

Closed ismail closed 10 months ago

ismail commented 10 months ago

Linux distributions set a bunch of flags during build among them are CFLAGS and LDFLAGS. Honor these so that we can build with the requested flags on these systems.

oliverkurth commented 10 months ago

Thank you for this, it looks good to me. I am just wondering if it would make sense to instead of appending the flags it would be better to overwrite them, like:

CFLAGS ?= -W -Wall -O2 -g

This would make it more flexible, OTOH if you need to add something you need to repeat the default flags.

I am just not sure what the canonical way is for this.

ismail commented 10 months ago

From my experience, expected behaviour would be to append.

oliverkurth commented 10 months ago

Checking something, will close and reopen. No worries.

oliverkurth commented 10 months ago

Reopening.

oliverkurth commented 10 months ago

@ismail ,

I am sorry for the trouble, but there is a legal requirement that you sign a CLA before contributing. Usually, for VMware projects, this is automatic but wasn't working here. The only way to make this work is if you create a new PR. So please do that, with identical content. You should be asked to sign the CLA, and when that is done I can merge.