vmware / photon-os-installer

Photon OS Installer
Other
12 stars 18 forks source link

use a blacklist instead of whitelist for disk devices, and refactor refresh_devices() method #24

Closed oliverkurth closed 9 months ago

oliverkurth commented 9 months ago

Fix for https://github.com/vmware/photon-os-installer/issues/23 , and refactor refactor refresh_devices() method. This now uses a list of devices to be excluded, instead if a list to be included. This allows for example virtio devices (253), but disallows for example floppy disks.

Also refactor to remove code duplication.

Tested by creating a custom iso with no kickstart (to allow interactive install) and installing in virt-manager.

Additionally, this includes example config files to create an ISO image. Instructions:

Prerequisites: docker with buildx plugin, a few GB of space (for docker images, package repository and ISO).

Steps:

You need to be root for all of the above, or use sudo (I tested this in a throw-away VM).